[libcxx-commits] [PATCH] D119791: [libcxx] [test] Fix locale.time.get.byname get_date and get_date_wide on Windows

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_date.pass.cpp:66
         const my_facet f(LOCALE_fr_FR_UTF_8, 1);
+#if defined(_WIN32) || defined(TEST_HAS_GLIBC)
+        const char in[] = "10/06/2009";
----------------
ldionne wrote:
> Why didn't the test fail on Glibc previously?
It previously failed on Glibc, but it still does - see the edited comment further up in the file. Previously it said:
```
// GLIBC Expects "10/06/2009" for fr_FR as opposed to "10.06.2009"
// GLIBC also fails on the zh_CN test.
// XFAIL: linux
```
Now I've edited it to say
```
// GLIBC fails on the zh_CN test.
// XFAIL: linux
```
(Fixing the `zh_CN` testcase on Glibc is a bigger issue, which requires fixes to the libc++ library implementation itself - I have a PoC of such a fix that I can send later.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119791/new/

https://reviews.llvm.org/D119791