[libcxx-commits] [PATCH] D119865: [libc++][nfc] Add TEST_HAS_NO_STRONG_ENUMS.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

In D119865#3326789 <https://reviews.llvm.org/D119865#3326789>, @Mordante wrote:

> Good point. It also seems Clang only supports it in C++11 and not in C++03.
> In that case I prefer to remove `_LIBCPP_HAS_NO_STRONG_ENUMS` from the codebase and test for C++03 instead.
> That the `_LIBCPP_DECLARE_STRONG_ENUM` macros will be gated by the language version.
> Agreed on this approach?

SGTM!
(I wondered if the `_LIBCPP_DECLARE_STRONG_ENUM` macro could be completely eliminated, but no, I see that we do have at least one use, in `<ios>`, that needs to keep working in C++03 mode. And also in `<future>` for some reason; and maybe all its uses.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119865/new/

https://reviews.llvm.org/D119865