[libcxx-commits] [PATCH] D119930: [libcxx] [test] Use proper UTF-8 locales on Windows

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp:22
+// or Windows 11).
+// XFAIL: windows
+
----------------
Would it be easy to detect the UCRT version in CMake and add an appropriate flag `libcpp-no-vcruntime`? Then we can use `UNSUPPORTED: libcpp-ucrt-has-utf8-bug`. That way others who want to test on Windows don't need to use the exact same version as the CI has.

When that's not possible I would prefer UNSUPPORTED over XFAIL. Again to avoid failing tests depending on which Windows platform they're executed on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119930/new/

https://reviews.llvm.org/D119930