[libcxx-commits] [PATCH] D118849: [SystemZ]:[z/OS]:[libcxx]: fix nthLetter issue for charconv header

Wed Feb 16 09:07:56 PST 2022

NancyWang2222 marked an inline comment as done.
NancyWang2222 added a comment.

ping :)

================
Comment at: libcxx/include/charconv:443
+  else if ('s' <= __c && __c <= 'z') return __c - 's' + 18;
+  else return 27;
+#else
----------------
SeanP wrote:
> NancyWang2222 wrote:
> > Mordante wrote:
> > > I'm not familiar with EBCDIC so I just assume this is correct.
> > it was tested on z/OS which has both ASCII and EBCDIC
> fyi ... if you want a reference to EBCDIC code points. http://en.wikipedia.org/wiki/Ebcdic.  Note EBCDIC has these "variant" code points that change value in different code pages (eg. 1047 vs others).  Some characters that change code point are '[', ']', '{', '}', '#' which is just awesome for C/C++ programming.
Thanks Sean. good information for anyone who wants to know about about EBCDIC. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118849/new/

https://reviews.llvm.org/D118849