[libcxx-commits] [libcxx] 79dc755 - [libc++] [test] Qualify calls to std::rethrow_exception. NFC.

Arthur O'Dwyer via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 16 08:04:20 PST 2022


Author: Arthur O'Dwyer
Date: 2022-02-16T11:03:34-05:00
New Revision: 79dc7551d83b0aa95366fdac64cd06367d75a088

URL: https://github.com/llvm/llvm-project/commit/79dc7551d83b0aa95366fdac64cd06367d75a088
DIFF: https://github.com/llvm/llvm-project/commit/79dc7551d83b0aa95366fdac64cd06367d75a088.diff

LOG: [libc++] [test] Qualify calls to std::rethrow_exception. NFC.

We shouldn't be calling `rethrow_exception` via ADL -- and neither should anybody
in the wild be calling it via ADL, so it's not like we need to test
this ADL ability of `rethrow_exception` in particular.

Reviewed as part of D119860.

Added: 
    

Modified: 
    libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
    libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
    libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp

Removed: 
    


################################################################################
diff  --git a/libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp b/libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
index 972649579b1e8..c37a6226c879b 100644
--- a/libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
+++ b/libcxx/test/std/language.support/support.exception/except.nested/assign.pass.cpp
@@ -49,7 +49,7 @@ int main(int, char**)
             assert(e.nested_ptr() != nullptr);
             try
             {
-                rethrow_exception(e.nested_ptr());
+                std::rethrow_exception(e.nested_ptr());
                 assert(false);
             }
             catch (const A& a)

diff  --git a/libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp b/libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
index 9d65f5fb22bdb..e1547575a85a8 100644
--- a/libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
+++ b/libcxx/test/std/language.support/support.exception/except.nested/ctor_copy.pass.cpp
@@ -47,7 +47,7 @@ int main(int, char**)
             assert(e.nested_ptr() != nullptr);
             try
             {
-                rethrow_exception(e.nested_ptr());
+                std::rethrow_exception(e.nested_ptr());
                 assert(false);
             }
             catch (const A& a)

diff  --git a/libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp b/libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp
index a96c3d015a18a..abb75e2d7017d 100644
--- a/libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp
+++ b/libcxx/test/std/language.support/support.exception/except.nested/ctor_default.pass.cpp
@@ -45,7 +45,7 @@ int main(int, char**)
             assert(e.nested_ptr() != nullptr);
             try
             {
-                rethrow_exception(e.nested_ptr());
+                std::rethrow_exception(e.nested_ptr());
                 assert(false);
             }
             catch (const A& a)


        


More information about the libcxx-commits mailing list