[libcxx-commits] [libcxx] 8f7f3c1 - [libc++] Pass -fcxx-modules during our modules builds

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 16 07:30:29 PST 2022


Author: Louis Dionne
Date: 2022-02-16T10:30:23-05:00
New Revision: 8f7f3c1f99169409e7a03cb1e03bcaac6ae82f6f

URL: https://github.com/llvm/llvm-project/commit/8f7f3c1f99169409e7a03cb1e03bcaac6ae82f6f
DIFF: https://github.com/llvm/llvm-project/commit/8f7f3c1f99169409e7a03cb1e03bcaac6ae82f6f.diff

LOG: [libc++] Pass -fcxx-modules during our modules builds

Otherwise, AppleClang ignores -fmodules entirely, so we are not actually
testing anything.

Differential Revision: https://reviews.llvm.org/D119862

Added: 
    

Modified: 
    libcxx/utils/libcxx/test/params.py

Removed: 
    


################################################################################
diff  --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py
index 211cd189df4a0..81a7d84a111b1 100644
--- a/libcxx/utils/libcxx/test/params.py
+++ b/libcxx/utils/libcxx/test/params.py
@@ -76,6 +76,7 @@ def getStdFlag(cfg, std):
             actions=lambda modules: [
               AddFeature('modules-build'),
               AddCompileFlag('-fmodules'),
+              AddCompileFlag('-fcxx-modules'), # AppleClang disregards -fmodules entirely when compiling C++. This enables modules for C++.
             ] if modules else []),
 
   Parameter(name='enable_exceptions', choices=[True, False], type=bool, default=True,


        


More information about the libcxx-commits mailing list