[libcxx-commits] [PATCH] D119894: [libc++] Add `explicit` to a bunch of private detail ctors.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a subscriber: philnik.
ldionne added a comment.
This revision now requires changes to proceed.

LGTM in essence, but the patch itself has a few mistakes (I think).



================
Comment at: libcxx/include/__memory/compressed_pair.h:44
+  template <class... _Args, size_t... _Indexes>
+  _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14
+  explicit __compressed_pair_elem(piecewise_construct_t, tuple<_Args...> __args,
----------------
This looks like a merge conflict to me -- you seem to have undone part of a recent patch by @philnik. Reintroducing `INLINE_VISIBILITY` and changing the template parameters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119894/new/

https://reviews.llvm.org/D119894