[libcxx-commits] [PATCH] D119931: [libcxx][atomic] Remove workaround for PR31864

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 16 06:12:06 PST 2022


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Looks pretty good, but I think we can dumb it down further.



================
Comment at: libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp:39
+#ifdef __GNUC__
+  assert(__atomic_always_lock_free(sizeof(long long), (long long*)alignof(long long)) == (2 == ATOMIC_LLONG_LOCK_FREE));
+  assert(__atomic_always_lock_free(sizeof(unsigned long long), (unsigned long long*)alignof(unsigned long long)) ==
----------------
We shouldn't need to check `__atomic_always_lock_free` at all, we're only trying to test `std::atomic<T>::is_always_lock_free`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119931/new/

https://reviews.llvm.org/D119931



More information about the libcxx-commits mailing list