[libcxx-commits] [PATCH] D119881: [libc++] Make cpp17_input_iterator constexpr
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Feb 15 12:38:25 PST 2022
Quuxplusone added a comment.
Seems plausible to me, but why on earth does this file exist? Shouldn't whoever-uses-it just be using `test/support/test_iterators.h` instead?
I notice that the header guard's name is incorrect too, and I assume that's simply an artifact of this file's getting accidentally caught up in the big `input_iterator`->`cpp17_input_iterator` rename circa last year.
Could you dig into whether we can just use `test_iterators.h` in the appropriate places and `git rm` this file?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119881/new/
https://reviews.llvm.org/D119881
More information about the libcxx-commits
mailing list