[libcxx-commits] [PATCH] D119836: [runtimes] Deprecate FOO_SYSROOT & friends

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/CMakeLists.txt:294
 
+if(NOT CMAKE_SYSROOT AND LIBCXX_SYSROOT)
+  message(WARNING "LIBCXX_SYSROOT is deprecated, please use CMAKE_SYSROOT instead")
----------------
phosek wrote:
> What's the motivation for checking if `CMAKE_SYSROOT` is unset and not just `LIBCXX_SYSROOT`?
If they are also setting `CMAKE_SYSROOT`, nothing will break when we remove `LIBCXX_SYSROOT`. I guess I could also just check for `LIBCXX_SYSROOT` if you have a preference for that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119836/new/

https://reviews.llvm.org/D119836