[libcxx-commits] [PATCH] D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.

Tue Feb 15 11:02:44 PST 2022

ldionne added a comment.

In D97044#3323827 <https://reviews.llvm.org/D97044#3323827>, @gulfem wrote:

> We started seeing the following issue before this patch got reverted in https://llvm.googlesource.com/llvm-project/+/987c7f407d1414a023f03eb788bb97667b479f27.
>
>   [48618/254381] CC efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o
>   FAILED: efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o
>   ../../../recipe_cleanup/clangc7enxobn/bin/clang -MD -MF efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o.d -o efi_x64/obj/src/firmware/gigaboot/src/src.avb.c.o -D_LIBCPP_DISABLE_VISIBILITY_ANNOTAT...
>   In file included from ../../src/firmware/gigaboot/src/avb.c:17:
>   In file included from ../../src/firmware/gigaboot/src/utf_conversion.h:6:
>   ../../zircon/system/public/zircon/types.h:554:9: error: unknown type name 'atomic_int'
>   typedef atomic_int zx_futex_t;
>           ^
>   1 error generated.
>
> https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8822209109414248273/overview

I can't see the full command-lines in the linked log. Can you try to reduce the issue you're seeing? I don't think this is the same thing as the LLDB issue, so this will break again when I re-commit this after fixing the LLDB issues.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97044/new/

https://reviews.llvm.org/D97044