[libcxx-commits] [PATCH] D108416: [llvm-libgcc] initial commit

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay added inline comments.


================
Comment at: llvm-libgcc/docs/LLVMLibgcc.rst:97
+It's very important to notice that neither `compiler-rt`, nor `llvm-libgcc`, are
+listed in `LLVM_ENABLE_RUNTIMES`. llvm-libgcc makes these subprojects, and adding
+them to this list will cause you problems.
----------------
I think some folks prefer that compiler-rt is added to LLVM_ENABLE_RUNTIMES. How difficult is it to make this work?

Note that current plan is that libunwind in DLLVM_ENABLE_PROJECTS will be unsupported.


================
Comment at: llvm-libgcc/generate_version_script.py:1
+#!/usr/bin/python
+
----------------
/usr/bin/env python3

Add a file-level comment what this script does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416