[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik marked 4 inline comments as done.
philnik added inline comments.


================
Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:12
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags}
+// -------------------------------------------------------------- ^ ignore GCC warnings unknown to clang
+
----------------
Quuxplusone wrote:
> The number of `-`s on this line will bit-rot quickly. Consider replacing with a full-sentence comment like
> ```
> // -Wno-unknown-warning-option tells clang-tidy to ignore "#pragma GCC diagnostic" options it doesn't recognize.
> ```
> Although, that shouldn't be a problem now that D119295 has landed. So can you remove `-Wno-unknown-warning-option` at this point? 
`-Wno-unknown-warning-options` is necessary so that clang-tidy ignores `-W*` command line arguments it doesn't know. I hope the new comment makes that clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174