[libcxx-commits] [PATCH] D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D97044#3322030 <https://reviews.llvm.org/D97044#3322030>, @mstorsjo wrote:

> This commit broke the CI, it triggers failures in the std/atomics/stdatomic.h.syn/types.compile.pass.cpp test on the GCC 11 / C++-latest configuration.

This was fixed by a30a7948d59470fe9403102b192b3e7ddaf21849 <https://reviews.llvm.org/rGa30a7948d59470fe9403102b192b3e7ddaf21849>.

In D97044#3323021 <https://reviews.llvm.org/D97044#3323021>, @shafik wrote:

> Looks like this commit broke the build for LLDB green dragon bots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41395/#showFailuresLink
>
> We are seeing 129 test failures with errors like this:
>
>   In file included from /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/__memory/shared_ptr.h:34:
>   /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/atomic:543:3: error: C++ standard library is incompatible with <stdatomic.h> before C++23. Please compile with -std=c++23.
>   # error C++ standard library is incompatible with <stdatomic.h> before C++23. Please compile with -std=c++23.
>     ^
>   /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/atomic:1075:25: error: expected ')'
>   _Tp kill_dependency(_Tp __y) _NOEXCEPT
>                           ^
>   /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/../include/c++/v1/atomic:1075:5: note: to match this '('
>   _Tp kill_dependency(_Tp __y) _NOEXCEPT
>       ^
>   /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lib/clang/15.0.99/include/stdatomic.h:65:28: note: expanded from macro 'kill_dependency'
>   #define kill_dependency(y) (y)
>                              ^

Looking into it. I suspect this is caused by the LLDB build doing something funky with include paths and the C standard library `<stdatomic.h>` being picked up before the libc++ one, but I'm not sure. Investigating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97044/new/

https://reviews.llvm.org/D97044