[libcxx-commits] [PATCH] D118188: [libcxx] [Windows] Pick a unique bit for __regex_word

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D118188#3321928 <https://reviews.llvm.org/D118188#3321928>, @vpalatin wrote:

> This is failing for **Newlib** / **Picolibc** too (defining `_NEWLIB_VERSION`).
>
> As far as I can tell, the `mask` there is a `char` and all 8 bits are currently defined in newlib:
>
>   #define _U      01
>   #define _L      02
>   #define _N      04
>   #define _S      010
>   #define _P      020
>   #define _C      040
>   #define _X      0100
>   #define _B      0200
>
> What would be the proper fix ?

Hmm, that looks problematic. I think you'd have to enlargen the `mask` type, which I would guess breaks the libc++ ABI for that platform - and I don't know if that one needs to match some size used by the libc too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118188/new/

https://reviews.llvm.org/D118188