[libcxx-commits] [PATCH] D119246: [libcxx][AIX][PowerPC] Disable workaround for PR31864 on powerpc

[Kai Luo via Phabricator via libcxx-commits]

lkail updated this revision to Diff 408716.
lkail added a comment.

Hi @ldionne , I've opened an issue on github https://github.com/llvm/llvm-project/issues/53840, do you agree we currently keep the workaround and unblock the AIX build?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119246/new/

https://reviews.llvm.org/D119246

Files:
  libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp


Index: libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
===================================================================
--- libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
+++ libcxx/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
@@ -8,9 +8,6 @@
 //
 // UNSUPPORTED: c++03, c++11, c++14
 
-// Fails for 32-bit builds.
-// UNSUPPORTED: LIBCXX-AIX-FIXME
-
 // <atomic>
 
 // static constexpr bool is_always_lock_free;
@@ -33,7 +30,7 @@
 // which causes ATOMIC_LLONG_LOCK_FREE to be defined as '1' in 32-bit builds
 // even though __atomic_always_lock_free returns true for the same type.
 constexpr bool NeedWorkaroundForPR31864 =
-#if defined(__clang__)
+#if defined(__clang__) && !defined(__powerpc__)
 (sizeof(void*) == 4); // Needed on 32 bit builds
 #else
 false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119246.408716.patch
Type: text/x-patch
Size: 821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220215/89a8e250/attachment-0001.bin>