[libcxx-commits] [PATCH] D119538: [libcxxabi] [test] Depend on unwind only if available

Michał Górny via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 14 15:40:43 PST 2022


mgorny added inline comments.


================
Comment at: libcxxabi/test/CMakeLists.txt:66
   list(APPEND LIBCXXABI_TEST_DEPS cxx)
-  if (LIBCXXABI_USE_LLVM_UNWINDER)
+  if (LIBCXXABI_USE_LLVM_UNWINDER AND TARGET unwind)
     list(APPEND LIBCXXABI_TEST_DEPS unwind)
----------------
ldionne wrote:
> Do I understand correctly that you're passing `LIBCXXABI_USE_LLVM_UNWINDER` but not including `libunwind` in `LLVM_ENABLE_RUNTIMES`? Is there a reason for doing that?
Yes, I'm linking to system-installed libunwind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119538/new/

https://reviews.llvm.org/D119538



More information about the libcxx-commits mailing list