[libcxx-commits] [PATCH] D119764: [libc++] Take more knobs into account when generating ABI lists

Mon Feb 14 14:48:56 PST 2022

ldionne added a comment.

In D119764#3320572 <https://reviews.llvm.org/D119764#3320572>, @Mordante wrote:

> I assume you'll add more abilist when the CI produces them?

I think the only ABI list missing is the one for arm64 apple-system. All the other CI configurations I added `check-abi-list` to are reusing existing ABI list files.

> I wonder whether we should use noincomplete or move them to the experimental library as you suggested earlier. I posted this question in Discord.

Replied on Discord, but TLDR is that I think we should handle that separately and avoid blocking this PR on it. Basically, what we want to do is merge the notion of incomplete features and experimental features, but that's a larger thing on its own and it should be coupled to compiler support for something like `-fexperimental`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119764/new/

https://reviews.llvm.org/D119764