[libcxx-commits] [PATCH] D97044: [libc++] [C++2b] [P0943] Add stdatomic.h header.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/atomics/stdatomic.h.syn/types.compile.pass.cpp:145-150
+  static_assert(std::memory_order_relaxed == ::memory_order_relaxed);
+  static_assert(std::memory_order_consume == ::memory_order_consume);
+  static_assert(std::memory_order_acquire == ::memory_order_acquire);
+  static_assert(std::memory_order_release == ::memory_order_release);
+  static_assert(std::memory_order_acq_rel == ::memory_order_acq_rel);
+  static_assert(std::memory_order_seq_cst == ::memory_order_seq_cst);
----------------
hubert.reinterpretcast wrote:
> It's simple enough to also check the type and lvalueness.
I'll use a slight variation on this by comparing the addresses, since that's simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97044/new/

https://reviews.llvm.org/D97044