[libcxx-commits] [PATCH] D118237: [libcxx] [test] Fix the get_weekday test on glibc

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 14 12:21:56 PST 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGe98f6fa1c7f9: [libcxx] [test] Fix the get_weekday test on glibc (authored by mstorsjo).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118237/new/

https://reviews.llvm.org/D118237

Files:
  libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp


Index: libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.time/locale.time.get.byname/get_weekday.pass.cpp
@@ -21,9 +21,6 @@
 // get_weekday(iter_type s, iter_type end, ios_base& str,
 //             ios_base::iostate& err, tm* t) const;
 
-// TODO: investigation needed
-// XFAIL: target={{.*}}-linux-gnu{{.*}}
-
 #include <locale>
 #include <cassert>
 #include "test_macros.h"
@@ -70,7 +67,13 @@
     }
     {
         const my_facet f(LOCALE_ru_RU_UTF_8, 1);
-        const char in[] = "\xD0\xBF\xD0\xBE\xD0\xBD\xD0\xB5"
+        const char in[] =
+#ifdef TEST_HAS_GLIBC
+                          "\xD0\x9F" // Upper case
+#else
+                          "\xD0\xBF" // Lower case
+#endif
+                          "\xD0\xBE\xD0\xBD\xD0\xB5"
                           "\xD0\xB4\xD0\xB5\xD0\xBB\xD1\x8C"
                           "\xD0\xBD\xD0\xB8\xD0\xBA";
         err = std::ios_base::goodbit;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118237.408558.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220214/15270c12/attachment.bin>


More information about the libcxx-commits mailing list