[libcxx-commits] [PATCH] D118238: [libcxx] [test] Simplify the handling of platform specific NAN formatting in put_long_double

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D118238#3319443 <https://reviews.llvm.org/D118238#3319443>, @Mordante wrote:

> In D118238#3319384 <https://reviews.llvm.org/D118238#3319384>, @Quuxplusone wrote:
>
>> I suggest an alternative approach, but I see no reason to block over that, so might as well accept. Feel free to adopt the `IF_GLIBC` idea or not, I guess.
>
> I don't mind that approach, but then I prefer a global macro. There are more localization tests disabled due to glibc giving a different result.

I think I'll go with my original approach for now. Especially in this test, I think that results in less clunky code. And for other tests, given that there's more than two platforms that may want to expect different results, the exact form of handling it can differ a bit between all tests. (FWIW I have a couple more glibc locale fixes in my queue in various state of finished, and a bunch of more windows locale fixes on top of those too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118238/new/

https://reviews.llvm.org/D118238