[libcxx-commits] [PATCH] D119561: [libc++] Replace `#include ""` with `<>` in libcxx/src/. NFCI

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Feb 14 08:28:57 PST 2022


ldionne accepted this revision as: ldionne.
ldionne added a comment.

I have to agree here, I think this is safe and in fact it's only a source of confusion that we're using `""` instead of `<>`. When we setup the libc++ build, we are careful to suppress the normal C++ stdlib header search paths with `nostdinc++`, and we add the path to the currently-being-built C++ stdlib explicitly using `-I` (or `-isystem`, I forgot).

So this LGTM: I don't think this **can** break anybody, but I'd like to make sure that @EricWF isn't aware of something we don't know before shipping this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119561/new/

https://reviews.llvm.org/D119561



More information about the libcxx-commits mailing list