[libcxx-commits] [PATCH] D119620: [libc++][ranges] Implement Ranges changes to `istream{, buf}_iterator`.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone requested changes to this revision.
Quuxplusone added a comment.
This revision now requires changes to proceed.

Er, actually, I spoke too soon...!  There are also test failures on Apple, because you changed the `operator==/!=` tests to include references to `default_sentinel`, and `default_sentinel` is disabled when `libcpp-has-no-concepts`.
I suggest fixing this by changing `<__iterator/default_sentinel.h>` to enable `default_sentinel` in C++20 regardless of `_LIBCPP_HAS_NO_CONCEPTS` — it should merely be guarded by `#if _LIBCPP_STD_VER > 17` and nothing else. However, now this has become a more involved change, and I think at least //I// should re-review it once the CI is green, and perhaps also someone else.

(Alternatively, you could split out the `default_sentinel`-related tests into separate test files and skip them for `libcpp-has-no-concepts` targets. But that seems yuckier.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119620/new/

https://reviews.llvm.org/D119620