[libcxx-commits] [PATCH] D119208: [libc++] WIP: use no_unique_address for base in join_view

[Joe Loser via Phabricator via libcxx-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f0b2ac140c3: [libc++] Use _LIBCPP_NO_UNIQUE_ADDRESS for base in join_view (authored by joe_loser).

Changed prior to commit:
  https://reviews.llvm.org/D119208?vs=406674&id=408083#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119208/new/

https://reviews.llvm.org/D119208

Files:
  libcxx/include/__ranges/join_view.h


Index: libcxx/include/__ranges/join_view.h
===================================================================
--- libcxx/include/__ranges/join_view.h
+++ libcxx/include/__ranges/join_view.h
@@ -68,7 +68,7 @@
     static constexpr bool _UseCache = !is_reference_v<_InnerRange>;
     using _Cache = _If<_UseCache, __non_propagating_cache<remove_cvref_t<_InnerRange>>, __empty_cache>;
     _LIBCPP_NO_UNIQUE_ADDRESS _Cache __cache_;
-    _View __base_ = _View(); // TODO: [[no_unique_address]] makes clang crash! File a bug :)
+    _LIBCPP_NO_UNIQUE_ADDRESS _View __base_ = _View();
 
   public:
     _LIBCPP_HIDE_FROM_ABI


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119208.408083.patch
Type: text/x-patch
Size: 621 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220211/1adc0612/attachment.bin>