[libcxx-commits] [PATCH] D119554: [compiler-rt] Force ABI to libcxxabi when building cxustom libc++

[Dimitry Andric via Phabricator via libcxx-commits]

dim added inline comments.


================
Comment at: compiler-rt/cmake/Modules/AddCompilerRT.cmake:638-642
+               -DLIBCXX_CXX_ABI=libcxxabi
                -DLIBCXXABI_ENABLE_SHARED=OFF
                -DLIBCXXABI_HERMETIC_STATIC_LIBRARY=ON
                -DLIBCXXABI_INCLUDE_TESTS=OFF
                -DLIBCXX_ENABLE_EXPERIMENTAL_LIBRARY=OFF
----------------
phosek wrote:
> Nit: can you move it down so that all libc++ options are kept together?
Ah sure, it looked to me like it belonged to the libcxxabi options, but indeed it is actually a `LIBCXX_*` option!



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119554/new/

https://reviews.llvm.org/D119554