[libcxx-commits] [PATCH] D119468: [libc++] Disable local submodule visibility in the modules build

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/test/params.py:74
 
   Parameter(name='enable_modules', choices=[True, False], type=bool, default=False,
             help="Whether to build the test suite with Clang modules enabled.",
----------------
aprantl wrote:
> I don't really understand the libcxx test configuration, but it looks like this changes the test that the std module can be built to not use LSV. Should we maybe test both LSV and non-LSV configs going forward?
Honestly, I'd rather just test the default `-fmodules` flag, that's it. I don't even know why we had LSV turned on previously. I have no desire to start supporting various ways to build with modules, just whatever the default modules build is. We don't really have that much CI hardware to spare.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119468/new/

https://reviews.llvm.org/D119468