[libcxx-commits] [PATCH] D119573: [libcxx] [ci] Enable LIBCXX_ENABLE_WERROR where possible

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D119573#3315185 <https://reviews.llvm.org/D119573#3315185>, @philnik wrote:

> I think you should put the `-DLIBCXX_ENABLE_WERROR=NO` in the cmake cache files. Why isn't there a cmake cache file for `generic-gcc` @ldionne?

There’s probably none, because no specific configuration is needed.

I don’t think we should involve the cmake cache files regarding LIBCXX_ENABLE_WERROR overall. Also, I think a command line argument (when enabled in run-buildbot) overrides what’s set in a cache file.

And I don’t think we should be enabling that option anywhere in the cache files. When building libcxx with the intent of *using* the library, we don’t want LIBCXX_ENABLE_WERROR enabled, because if it builds successfully, it’s probably fine to use even if it produced warnings. Enabling it should be strictly a CI thing (and when developing the library , if such a setup is wanted).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119573/new/

https://reviews.llvm.org/D119573