[libcxx-commits] [PATCH] D117174: [libc++][test] Run clang-tidy during CI

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 11 10:17:41 PST 2022


philnik added inline comments.


================
Comment at: libcxx/test/libcxx/clang_tidy.sh.cpp:9-12
+// UNSUPPORTED: !has-clang-tidy
+// XFAIL: modules
+// RUN: clang-tidy %s --warnings-as-errors=* -header-filter=.* -- -Wno-unknown-warning-option %{compile_flags}
+// -------------------------------------------------------------- ^ ignore GCC warnings unknown to clang
----------------
Quuxplusone wrote:
> > `XFAIL: modules`
> What's the problem with modules? (Preferably in the form of an English explanation //plus// a link to the failing buildkite.)
https://buildkite.com/llvm-project/libcxx-ci/builds/8619
It complains with `use of private header from outside its module` and `function-like macro '__has_keyword' is not defined`. Also a few other macros.


================
Comment at: libcxx/utils/libcxx/test/features.py:107-108
+
+  Feature(name='has-clang-tidy',
+          when=lambda cfg: runScriptExitCode(cfg, ['clang-tidy --version']) == 0),
 ]
----------------
Quuxplusone wrote:
> Consider indenting to match the other lines.
Moved it up to 'executor-has-no-bash'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117174/new/

https://reviews.llvm.org/D117174



More information about the libcxx-commits mailing list