[libcxx-commits] [PATCH] D119152: [libc++] Implement P0627R6 (Function to mark unreachable code)

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for working on this!



================
Comment at: libcxx/include/__utility/unreachable.h:10
+#ifndef _LIBCPP___UTILITY_UNREACHABLE_H
+#define _LIBCPP___UTILITY_UNREACHABLE_H
+
----------------
Please update `utils/generate_feature_test_macro_components.py` to provide the `__cpp_lib_unreachable` feature-test macro.


================
Comment at: libcxx/include/__utility/unreachable.h:12
+
+#include <__config>
+
----------------
`std::abort` requires `#include <cstdlib>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119152/new/

https://reviews.llvm.org/D119152