[libcxx-commits] [PATCH] D119561: [libc++] Replace `#include ""` with `<>` in libcxx/src/. NFCI

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 11 10:04:27 PST 2022


Quuxplusone created this revision.
Quuxplusone added reviewers: philnik, ldionne, libc++.
Quuxplusone added a project: libc++.
Herald added a subscriber: smeenai.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added 1 blocking reviewer(s): libc++.

Our best guess is that the two syntaxes should have exactly equivalent
effects, so, let's be consistent with what we do in libcxx/include/.

I've left `#include "include/x.h"` and `#include "../y.h"` alone
because I'm less sure that they're interchangeable, and they aren't
inconsistent with libcxx/include/ because libcxx/include/ never
does that kind of thing.

Also, use the `_LIBCPP_PUSH_MACROS/POP_MACROS` dance for `<__undef_macros>`,
even though it's technically unnecessary in a standalone .cpp file,
just so we have consistently one way to do it.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D119561

Files:
  libcxx/src/algorithm.cpp
  libcxx/src/any.cpp
  libcxx/src/bind.cpp
  libcxx/src/charconv.cpp
  libcxx/src/chrono.cpp
  libcxx/src/condition_variable.cpp
  libcxx/src/condition_variable_destructor.cpp
  libcxx/src/debug.cpp
  libcxx/src/exception.cpp
  libcxx/src/experimental/memory_resource.cpp
  libcxx/src/filesystem/directory_iterator.cpp
  libcxx/src/filesystem/filesystem_common.h
  libcxx/src/filesystem/int128_builtins.cpp
  libcxx/src/filesystem/operations.cpp
  libcxx/src/filesystem/posix_compat.h
  libcxx/src/format.cpp
  libcxx/src/functional.cpp
  libcxx/src/future.cpp
  libcxx/src/hash.cpp
  libcxx/src/include/atomic_support.h
  libcxx/src/include/ryu/d2fixed.h
  libcxx/src/include/ryu/d2fixed_full_table.h
  libcxx/src/include/ryu/d2s.h
  libcxx/src/include/ryu/d2s_full_table.h
  libcxx/src/include/ryu/d2s_intrinsics.h
  libcxx/src/include/ryu/digit_table.h
  libcxx/src/include/ryu/f2s.h
  libcxx/src/include/ryu/ryu.h
  libcxx/src/include/to_chars_floating_point.h
  libcxx/src/ios.cpp
  libcxx/src/ios.instantiations.cpp
  libcxx/src/iostream.cpp
  libcxx/src/legacy_pointer_safety.cpp
  libcxx/src/locale.cpp
  libcxx/src/memory.cpp
  libcxx/src/mutex.cpp
  libcxx/src/mutex_destructor.cpp
  libcxx/src/new.cpp
  libcxx/src/optional.cpp
  libcxx/src/random.cpp
  libcxx/src/random_shuffle.cpp
  libcxx/src/regex.cpp
  libcxx/src/ryu/d2fixed.cpp
  libcxx/src/ryu/d2s.cpp
  libcxx/src/ryu/f2s.cpp
  libcxx/src/shared_mutex.cpp
  libcxx/src/stdexcept.cpp
  libcxx/src/string.cpp
  libcxx/src/strstream.cpp
  libcxx/src/system_error.cpp
  libcxx/src/thread.cpp
  libcxx/src/typeinfo.cpp
  libcxx/src/utility.cpp
  libcxx/src/valarray.cpp
  libcxx/src/variant.cpp
  libcxx/src/vector.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119561.407933.patch
Type: text/x-patch
Size: 30305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220211/42af5469/attachment-0001.bin>


More information about the libcxx-commits mailing list