[libcxx-commits] [PATCH] D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__locale:571
 
+    static bool __is_valid_in_encoding(char_type __c)
+    {
----------------
Here and below.


================
Comment at: libcxx/include/__locale:685
+#if defined(__MVS__)
+        return __c ? true : true;
+#else
----------------
NancyWang2222 wrote:
> NancyWang2222 wrote:
> > Mordante wrote:
> > > Is this intended to always return true, if you please just return `true`. You can use a `(void) __c;` to silence compiler diagnostics.
> > clang will emit error if argument __c is not used in function. that is why I checked __c. 
> I will add void(__c); 
Why is this intended to always return true?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118851/new/

https://reviews.llvm.org/D118851