[libcxx-commits] [PATCH] D119430: [libcxx] Wrap [[no_unique_address]] in a macro, for clang-cl

[Joe Loser via Phabricator via libcxx-commits]

jloser added inline comments.


================
Comment at: libcxx/include/__ranges/join_view.h:71
+    _LIBCPP_NO_UNIQUE_ADDRESS _Cache __cache_;
+    _View __base_ = _View(); // TODO: _LIBCPP_NO_UNIQUE_ADDRESS makes clang crash! File a bug :)
 
----------------
Quuxplusone wrote:
> mstorsjo wrote:
> > philnik wrote:
> > > I'd personally keep `[[no_unique_address]]` here.
> > Oh, oops. Yes this is a victim of search-and-replace...
> Nobody knows why this comment is here; we should just remove it. But D119208 is related (and attn @jloser, for the merge conflict that will inevitably occur here)
@Quuxplusone thanks for the ping here. I certainly don't know why the comment is here as you know. I'd be OK removing it (and also marking `__base_` as `_LIBCPP_NO_UNIQUE_ADDRESS` FWIW - effectively what I did in https://reviews.llvm.org/D119208)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119430/new/

https://reviews.llvm.org/D119430