[libcxx-commits] [PATCH] D119439: [libc++] Remove __functional_base

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

LGTM //except// that I'd like to see `#include <functional>` moved
from `test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/deduct.pass.cpp`
into `test/support/deduction_guides_sfinae_checks.h` before this lands. Since, if that doesn't work, then we don't understand something here, and we ought to understand it before we land it.



================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/deduct.pass.cpp:22
 
+#include <functional>
 #include <memory>
----------------
Quuxplusone wrote:
> philnik wrote:
> > Quuxplusone wrote:
> > > This doesn't look needed. Why would we need this here?
> > This is needed in `deduction_guides_sfinare_checks.h` for `std::equal_to` (I think). Including it directly in the header didn't work. I'm not sure if this is a compiler bug, or if it's intended.
> Including `<functional>` from `deduction_guides_sfinae_checks.h` didn't work? Can you link to the CI results (or reupload to generate some new CI results)?
> Or, since this is moot after the Hyrum's Law thing, IMHO you could just not touch this file and leave it for later investigation (at whatever time in the future we make `<memory>` stop providing a definition for `std::equal_to`).
> Including <functional> from deduction_guides_sfinae_checks.h didn't work? Can you link to the CI results (or reupload to generate some new CI results)?

Let's figure out what's going on here, before landing this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119439/new/

https://reviews.llvm.org/D119439