[libcxx-commits] [PATCH] D116974: [libc++] Add ranges::in_fun_result

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 11 08:10:36 PST 2022


philnik marked 3 inline comments as done.
philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/algorithms.results/no_unique_address.compile.pass.cpp:24
 struct Empty {};
 
 static_assert(sizeof(std::ranges::in_in_result<Empty, int>) == sizeof(int));
----------------
Quuxplusone wrote:
> var-const wrote:
> > Can you please move the corresponding tests in `in_out_result.compile.pass.cpp` to this file for consistency? (not necessarily in this patch)
> This was marked "Done", but not done. Since you moved the synopsis comment for `in_out_result`, I think it would be nice to also move the mentioned tests in this same commit. But if it happens in a followup, also cool.
I'll do it in the results cleanup PR. The synopsis are just to easy to miss for my taste, so I moved them here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116974/new/

https://reviews.llvm.org/D116974



More information about the libcxx-commits mailing list