[libcxx-commits] [PATCH] D119497: [libc++] Replace _VSTD with std in __ranges/

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Feb 11 07:32:12 PST 2022


Quuxplusone added 1 blocking reviewer(s): ldionne.
Quuxplusone added a comment.

Assuming this is a completely mechanical `sed -i -e s/_VSTD::/std::/g ../libcxx/include/__ranges/*.h`, and assuming that you'll actually redo the `sed` immediately before pushing it (to avoid any merge/rebase conflicts), this seems technically fine to me.
My impression is that we absolutely //don't// want to do this kind of replacement on e.g. `__algorithm/`, `__memory/`, etc, because that would annoy downstream vendors; but perhaps `__ranges/` is so new that it's a special case? Therefore I defer to @ldionne on this more-political-than-technical question.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119497/new/

https://reviews.llvm.org/D119497



More information about the libcxx-commits mailing list