[libcxx-commits] [PATCH] D116689: [libunwind][libcxxabi] Use object libraries in the build

[Petr Hosek via Phabricator via libcxx-commits]

phosek added inline comments.


================
Comment at: libcxx/src/CMakeLists.txt:233
+    elseif (LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY AND (TARGET unwind_shared_objects OR HAVE_LIBUNWIND))
+      target_link_libraries(cxx_shared PUBLIC unwind_shared_objects)
     else()
----------------
ldionne wrote:
> compnerd wrote:
> > Why not use `TARGET_OBJECTS:unwind>` instead?
> I have the same question.
AFAIK I can only use `TARGET_OBJECTS` against object library so I need to do `$<TARGET_OBJECTS:unwind_shared_objects>` which works but doesn't simplify things much. Did you have something else in mind?


================
Comment at: libcxx/src/CMakeLists.txt:340
+
+      set(MERGE_ARCHIVES_SEARCH_PATHS "")
+      if (LIBCXX_CXX_ABI_LIBRARY_PATH)
----------------
ldionne wrote:
> Why do we need this at all now? I must have misunderstood something, but I thought we were handling the merging of archives via those object libraries now.
I left this for other C++ABI libraries such as libcxxrt where we cannot use archives directly as object libraries and have to fallback to archive merging. I'm not sure if that's a use case we want to support, but we do support it now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116689/new/

https://reviews.llvm.org/D116689