[libcxx-commits] [PATCH] D115906: [libc++] Add a bunch of missing inline and _LIBCPP_HIDE_FROM_ABI in __threading_support

Thu Feb 10 14:15:05 PST 2022

ldionne added a comment.

In D115906#3310651 <https://reviews.llvm.org/D115906#3310651>, @miyuki wrote:

> In D115906#3308435 <https://reviews.llvm.org/D115906#3308435>, @DanielMcIntosh-IBM wrote:
>
>> Ping, since as per my previous comment, I'm pretty sure this change will have broken `_LIBCPP_BUILDING_THREAD_LIBRARY_EXTERNAL`.
>
> Yes, indeed it has.

Sorry, this went under my radar. I just spun off a patch to revert this. If it passes, I'll cherry-pick onto LLVM 14.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115906/new/

https://reviews.llvm.org/D115906