[libcxx-commits] [PATCH] D119057: [libc++][ranges] Implement rbegin, rend, crbegin and crend.

[Konstantin Varlamov via Phabricator via libcxx-commits]

var-const updated this revision to Diff 407625.
var-const marked 6 inline comments as done.
var-const added a comment.

- replace `class __fn` with `struct __fn` (in `rend.h` and `access.h`);
- make overloads that return `std::make_reverse_iterator` return `auto`, not `decltype(expr)`;
- include `reverse_iterator.h` in `rend.h` to hopefully fix the modular build.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119057/new/

https://reviews.llvm.org/D119057

Files:
  libcxx/docs/Status/RangesPaper.csv
  libcxx/include/CMakeLists.txt
  libcxx/include/__concepts/class_or_enum.h
  libcxx/include/__ranges/access.h
  libcxx/include/__ranges/rbegin.h
  libcxx/include/__ranges/rend.h
  libcxx/include/module.modulemap
  libcxx/include/ranges
  libcxx/test/libcxx/diagnostics/detail.headers/ranges/rbegin.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/ranges/rend.module.verify.cpp
  libcxx/test/std/ranges/range.access/begin.pass.cpp
  libcxx/test/std/ranges/range.access/end.pass.cpp
  libcxx/test/std/ranges/range.access/rbegin.pass.cpp
  libcxx/test/std/ranges/range.access/rend.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D119057.407625.patch
Type: text/x-patch
Size: 67268 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20220210/e52f11cc/attachment-0001.bin>