[libcxx-commits] [PATCH] D119134: [libcxx] Silence -Wformat-nonliteral warnings in the Windows support code

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:604
     generate-cmake \
+          -DLIBCXX_ENABLE_WERROR=ON \
           -DCMAKE_C_COMPILER=x86_64-w64-mingw32-clang \
----------------
ldionne wrote:
> Would you be OK with moving it to the CMake cache instead?
I think I’d omit this from this particular patch, and once D119430 lands, I’d make a different patch for enabling `LIBCXX_ENABLE_WERROR` - which would be opt-out for the few configs that don’t pass in that mode. But let’s move that to a later discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119134/new/

https://reviews.llvm.org/D119134