[libcxx-commits] [PATCH] D119152: [libc++] Implement P0627R6 (Function to mark unreachable code)
Nikolas Klauser via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 10 11:08:27 PST 2022
philnik marked 3 inline comments as done.
philnik added inline comments.
================
Comment at: libcxx/include/charconv:90
#include <cstdint>
#include <cstdlib> // for _LIBCPP_UNREACHABLE
#include <cstring>
----------------
Quuxplusone wrote:
> Can we remove this? If not, let's at least remove the comment (which is wrong now).
I wouldn't play with the header includes in this PR. We have to go through all headers anyways and remove unused includes.
================
Comment at: libcxx/include/fstream:188
#include <cstdio>
#include <cstdlib>
#include <istream>
----------------
Quuxplusone wrote:
> Can we remove this now? (The answer, if "yes", will depend partly on politics: are we OK with breaking users who `#include <fstream>` and then call `malloc` or whatever.)
Same as above.
================
Comment at: libcxx/src/filesystem/filesystem_common.h:13
#include "__config"
+#include <__utility/unreachable.h>
#include "array"
----------------
Quuxplusone wrote:
> As you probably noticed, right now this file uses `#include "..."` over `#include <...>`, and doesn't include any detail headers directly. I think there's no particular reason to preserve these invariants, but probably we want to `s/""/<>/` in this file //before// we start mixing `<>` into it.
Would you also be OK with me making a followup PR to clean up all the includes in `src/`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119152/new/
https://reviews.llvm.org/D119152
More information about the libcxx-commits
mailing list