[libcxx-commits] [PATCH] D119439: [libc++] Remove __functional_base

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 10 10:55:49 PST 2022


Quuxplusone added inline comments.


================
Comment at: libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.ctor/deduct.pass.cpp:22
 
+#include <functional>
 #include <memory>
----------------
philnik wrote:
> Quuxplusone wrote:
> > This doesn't look needed. Why would we need this here?
> This is needed in `deduction_guides_sfinare_checks.h` for `std::equal_to` (I think). Including it directly in the header didn't work. I'm not sure if this is a compiler bug, or if it's intended.
Including `<functional>` from `deduction_guides_sfinae_checks.h` didn't work? Can you link to the CI results (or reupload to generate some new CI results)?
Or, since this is moot after the Hyrum's Law thing, IMHO you could just not touch this file and leave it for later investigation (at whatever time in the future we make `<memory>` stop providing a definition for `std::equal_to`).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119439/new/

https://reviews.llvm.org/D119439



More information about the libcxx-commits mailing list