[libcxx-commits] [PATCH] D118851: [SystemZ]:[z/OS]:[libcxx]: fix isascii function to work for z/OS

Nancy Wang via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 10 09:31:27 PST 2022


NancyWang2222 marked 5 inline comments as done.
NancyWang2222 added inline comments.


================
Comment at: libcxx/src/locale.cpp:1026
 #elif defined(__NetBSD__)
         *low = static_cast<char>(__classic_upper_table()[static_cast<unsigned char>(*low)]);
 #elif defined(__GLIBC__) || defined(__EMSCRIPTEN__) || defined(__MVS__)
----------------
Mordante wrote:
> I don't mind the formatting in the other `#if` blocks, but then please update the indention here also.
> Please also look at the other indention changes you made.
sure . I will update it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118851/new/

https://reviews.llvm.org/D118851



More information about the libcxx-commits mailing list