[libcxx-commits] [PATCH] D117817: [libc++][ranges] Implement ranges::mismatch

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Feb 10 09:25:56 PST 2022


philnik added inline comments.


================
Comment at: libcxx/test/std/algorithms/alg.nonmodifying/mismatch/ranges_mismatch.pass.cpp:21
+template <class Iter1, class Iter2>
+constexpr void test_iterators(Iter1 begin1, Iter1 end1, Iter2 begin2, Iter2 end2, int* expected1, int* expected2) {
+  using Expected = std::ranges::mismatch_result<Iter1, Iter2>;
----------------
ldionne wrote:
> You could easily inline that function into the only place where it's called (unless I missed a second usage?).
It's also used in `test_different_lengths()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117817/new/

https://reviews.llvm.org/D117817



More information about the libcxx-commits mailing list