[libcxx-commits] [PATCH] D117025: [libc++][ranges] Implement ranges::min_element
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Feb 10 09:11:22 PST 2022
Mordante accepted this revision as: Mordante.
Mordante added a comment.
LGTM modulo one suggestion.
================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.min_element.pass.cpp:107
+constexpr void test_borrowed_range_and_sentinel() {
+ int a[] = {7, 6, 1, 3, 5, 1, 2, 4};
+
----------------
For reviewing it would be nice to also validate the value assert(*ret == x); in all these tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117025/new/
https://reviews.llvm.org/D117025
More information about the libcxx-commits
mailing list