[libcxx-commits] [PATCH] D117523: [libc++][ranges] Implement ranges::max_element

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D117523#3308729 <https://reviews.llvm.org/D117523#3308729>, @philnik wrote:

> In D117523#3308721 <https://reviews.llvm.org/D117523#3308721>, @Mordante wrote:
>
>> In general looks good, but I'd like a bit more test coverage.
>
> Could you first review D117025 <https://reviews.llvm.org/D117025>? It's basically the same. I'll apply the changes there over here, once D117025 <https://reviews.llvm.org/D117025> is done.

I'll look at it.



================
Comment at: libcxx/test/std/algorithms/alg.sorting/alg.min.max/ranges.max_element.pass.cpp:83
+}
+
+constexpr void test_borrowed_range_and_sentinel() {
----------------
Mordante wrote:
> I would like a test where the maximum value occurs twice to validate whether it returns the first, per `Returns: The first iterator i in the range…`.
> 
I see in D117025 it has two times a `min_element` of 1 in the test at line 85.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117523/new/

https://reviews.llvm.org/D117523