[libcxx-commits] [PATCH] D119036: [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I managed to reproduce with a freshly-built Clang + libc++ and this:

  echo "#include <cstddef>" | xcrun ./build/default/bin/clang++ -fmodules -xc++ - -fsyntax-only

This is caused by making the `__config` header a `textual` header. However, adding `-Xclang -fmodules-local-submodule-visibility` fixes the issue:

  echo "#include <cstddef>" | xcrun ./build/default/bin/clang++ -fmodules -xc++ - -Xclang -fmodules-local-submodule-visibility -fsyntax-only

works just fine. And in fact, that's how we run our own Modules build (which we set up specifically to avoid breaking LLDB).

Could LLDB build with that flag so that our flags match?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119036/new/

https://reviews.llvm.org/D119036