[libcxx-commits] [PATCH] D119036: [libc++] Fix modules and benchmarks CI builds when incomplete features are disabled

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D119036#3310455 <https://reviews.llvm.org/D119036#3310455>, @rastogishubham wrote:

> Hi this commit broke the lldb greendragon bots.
>
> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/41225/
>
> crashlog backtrace:
>
> [...]
>
> Target: x86_64-apple-darwin19.5.0
> Thread model: posix
> InstalledDir: /Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin
> clang-15: error: unable to execute command: Abort trap: 6
> clang-15: note: diagnostic msg: Error generating preprocessed source(s).
> make: *** [main.o] Error 134

That's not really helpful -- can you please reduce some more? I'm not even able to run the LLDB tests locally, it complains about missing SWIG even though I did install it. Regardless, it looks like at the end of the day your bot is running something like this:

  "/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/bin/clang"  -fmodules -gmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-api -gmodules -fcxx-modules -std=c++11 -g -O0 -fno-builtin -isysroot "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk" -arch x86_64  -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/../../../../../include -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/functionalities/thread/state_after_expression -I/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make -include /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/make/test_common.h  -fno-limit-debug-info  -fmodules -gmodules -fmodules-cache-path=/Users/buildslave/jenkins/workspace/lldb-cmake/lldb-build/lldb-test-build.noindex/module-cache-clang/lldb-api -gmodules -fcxx-modules -std=c++11   --driver-mode=g++ -MT main.o -MD -MP -MF main.d -c -o main.o /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/functionalities/thread/state_after_expression/main.cpp

So I think this is just a modules bug in Clang. I'll be happy to investigate if I can reproduce it.

Also, LLDB is still using the deprecated `LLVM_ENABLE_PROJECTS` build for libc++ and libc++abi -- please move to `LLVM_ENABLE_RUNTIMES` as documented here: https://libcxx.llvm.org/BuildingLibcxx.html.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119036/new/

https://reviews.llvm.org/D119036