[libcxx-commits] [PATCH] D119430: [libcxx] Wrap [[no_unique_address]] in a macro, for clang-cl

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D119430#3310901 <https://reviews.llvm.org/D119430#3310901>, @mstorsjo wrote:

> With this (and D119134 <https://reviews.llvm.org/D119134>) I think we could enable `LIBCXX_ENABLE_WERROR` in all CI configurations except for the couple GCC ones.
>
> GCC builds seem to print (at least) this warning when building:
>
>   include/c++/v1/string:2267:32: error: enumerated and non-enumerated type in conditional expression [-Werror=extra]
>    2267 |   size_type __cap = __is_short ? __min_cap : __get_long_cap();

I'm working on making the GCC build warning-free, but I don't know how long it will take. There are still quite a few problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119430/new/

https://reviews.llvm.org/D119430