[libcxx-commits] [PATCH] D119255: [runtimes] Remove support for standalone builds

[Simon Moll via Phabricator via libcxx-commits]

simoll added a comment.

In D119255#3307824 <https://reviews.llvm.org/D119255#3307824>, @ldionne wrote:

> @simoll You are marked as responsible for the `clang-ve-ninja` built bot that broke because of this change here: https://lab.llvm.org/buildbot/#/builders/91/builds/3480.
>
> Are you able to move that bot to the normal runtimes build? Right now the bot is doing:
>
>   cd "/scratch/buildbot/bothome/clang-ve-ninja/build/build_libunwind_ve" && cmake /scratch/buildbot/bothome/clang-ve-ninja/build/../llvm-project/libunwind -G Ninja \
>       -DLIBUNWIND_TARGET_TRIPLE=""ve-linux"" \
>       -DCMAKE_C_COMPILER="""/scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm""/bin/clang" \
>       -DCMAKE_CXX_COMPILER="""/scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm""/bin/clang++" \
>       -DCMAKE_AR=""/scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm""/bin/llvm-ar \
>       -DCMAKE_RANLIB=""/scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm""/bin/llvm-ranlib \
>       -DCMAKE_C_COMPILER_TARGET=""ve-linux"" \
>       -DCMAKE_CXX_COMPILER_TARGET=""ve-linux"" \
>       -DCMAKE_BUILD_TYPE="Release" \
>       -DCMAKE_INSTALL_PREFIX=""""/scratch/buildbot/bothome/clang-ve-ninja/build/build_llvm""/lib/clang/15.0.0"" \
>       -DLIBUNWIND_LIBDIR_SUFFIX="/linux/ve" \
>       -DCMAKE_CXX_FLAGS="-nostdlib" \
>       -DCMAKE_CXX_FLAGS_RELEASE="-O2" \
>       -DCMAKE_C_FLAGS="-nostdlib" \
>       -DCMAKE_C_FLAGS_RELEASE="-O2" \
>       -DLIBUNWIND_LIBCXX_PATH=/scratch/buildbot/bothome/clang-ve-ninja/build/../llvm-project/libcxx \
>       -DLLVM_PATH=/scratch/buildbot/bothome/clang-ve-ninja/build/../llvm-project/llvm
>
> Instead, you want to be doing something like this:
>
>   cmake -S llvm-project/runtimes -B <BUILD_DIR> -G Ninja \
>       -DLIBUNWIND_TARGET_TRIPLE=""ve-linux"" \
>       -DCMAKE_C_COMPILER="<whatever>" \
>       -DCMAKE_CXX_COMPILER="<whatever>" \
>       -DCMAKE_AR="<whatever>" \
>       -DCMAKE_RANLIB=""<whatever>" \
>       -DCMAKE_C_COMPILER_TARGET="ve-linux" \
>       -DCMAKE_CXX_COMPILER_TARGET="ve-linux" \
>       -DCMAKE_BUILD_TYPE="Release" \
>       -DCMAKE_INSTALL_PREFIX="<whatever>" \
>       -DLIBUNWIND_LIBDIR_SUFFIX="/linux/ve" \
>       -DCMAKE_CXX_FLAGS="-nostdlib" \
>       -DCMAKE_CXX_FLAGS_RELEASE="-O2" \
>       -DCMAKE_C_FLAGS="-nostdlib" \
>       -DCMAKE_C_FLAGS_RELEASE="-O2" \
>       -DLLVM_ENABLE_RUNTIMES="libunwind"
>
> So basically, use `<monorepo>/runtimes` as the root of the CMake tree, drop `LIBUNWIND_LIBCXX_PATH` and `LLVM_PATH`, and add `-DLLVM_ENABLE_RUNTIMES="libunwind"`.

Thanks. We are testing this now and will switch to a runtimes build soon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119255/new/

https://reviews.llvm.org/D119255