[libcxx-commits] [PATCH] D119264: [libc++] Rename *SAFE_STATIC to *CONSTINIT, and normalize its uses.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Feb 9 14:42:44 PST 2022


ldionne added a comment.

In D119264#3309220 <https://reviews.llvm.org/D119264#3309220>, @Quuxplusone wrote:

> Fix the failing tests (forgot to remove a use of the removed constinit variable), and use `constinit` directly in libcxx/src/.
> Should I use `constinit` directly in `libcxxabi/src/` too? So far I have not.

I think you can, since we require CXX20 from the libc++abi CMake too. I think I checked yesterday and that was the case. If you try and it fails while building libc++abi, you'll have your answer.

This is why keeping compiler requirements fairly up-to-date is nice -- we don't have to jump through too many hoops in the sources at least.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119264/new/

https://reviews.llvm.org/D119264



More information about the libcxx-commits mailing list